@@ -0,0 +1,144 @@
|
||||
package service
|
||||
|
||||
import (
|
||||
"context"
|
||||
"crypto/rand"
|
||||
"crypto/sha256"
|
||||
"encoding/base64"
|
||||
"encoding/hex"
|
||||
"errors"
|
||||
"fmt"
|
||||
"regexp"
|
||||
"strings"
|
||||
"time"
|
||||
"unicode/utf8"
|
||||
"veyra/services/api/internal/platform/apperror"
|
||||
|
||||
"github.com/google/uuid"
|
||||
"golang.org/x/crypto/bcrypt"
|
||||
"veyra/services/api/internal/identity/domain"
|
||||
)
|
||||
|
||||
type Repository interface {
|
||||
CreateUser(context.Context, domain.User, domain.Credential) (domain.User, error)
|
||||
FindCredential(context.Context, string) (domain.User, domain.Credential, error)
|
||||
CreateSession(context.Context, domain.Session) error
|
||||
FindSessionUser(context.Context, string, string, time.Time) (domain.User, error)
|
||||
RevokeSession(context.Context, string, string, time.Time) error
|
||||
ListUsers(context.Context, int) ([]domain.User, error)
|
||||
}
|
||||
|
||||
type AuthService struct {
|
||||
repo Repository
|
||||
now func() time.Time
|
||||
dummyHash []byte
|
||||
}
|
||||
|
||||
func NewAuthService(repo Repository) (*AuthService, error) {
|
||||
hash, err := bcrypt.GenerateFromPassword([]byte("invalid-user-timing-placeholder"), bcrypt.DefaultCost)
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("initialize password verifier: %w", err)
|
||||
}
|
||||
return &AuthService{repo: repo, now: time.Now, dummyHash: hash}, nil
|
||||
}
|
||||
|
||||
var loginPattern = regexp.MustCompile(`^[a-z0-9_]{3,64}$`)
|
||||
|
||||
// ProvisionUser is called by a local CLI. Public registration cannot choose ADMIN.
|
||||
func (s *AuthService) ProvisionUser(ctx context.Context, login, password, name, role string) (domain.User, error) {
|
||||
login = strings.ToLower(strings.TrimSpace(login))
|
||||
name = strings.TrimSpace(name)
|
||||
if !loginPattern.MatchString(login) || len(password) < 12 || len(password) > 72 || utf8.RuneCountInString(name) > 80 || name == "" || (role != "USER" && role != "ADMIN") {
|
||||
return domain.User{}, apperror.ErrInvalidInput
|
||||
}
|
||||
if s.repo == nil {
|
||||
return domain.User{}, apperror.ErrUnavailable
|
||||
}
|
||||
hash, err := bcrypt.GenerateFromPassword([]byte(password), bcrypt.DefaultCost)
|
||||
if err != nil {
|
||||
return domain.User{}, fmt.Errorf("hash password: %w", err)
|
||||
}
|
||||
user := domain.User{ID: uuid.NewString(), DisplayName: name, Status: "ACTIVE", Role: role}
|
||||
credential := domain.Credential{ID: uuid.NewString(), UserID: user.ID, LoginName: login, PasswordHash: string(hash)}
|
||||
return s.repo.CreateUser(ctx, user, credential)
|
||||
}
|
||||
|
||||
type LoginResult struct {
|
||||
User domain.User
|
||||
Token string
|
||||
ExpiresAt time.Time
|
||||
}
|
||||
|
||||
func (s *AuthService) Login(ctx context.Context, login, password, audience string) (LoginResult, error) {
|
||||
if audience != "admin" && audience != "app" {
|
||||
return LoginResult{}, apperror.ErrInvalidInput
|
||||
}
|
||||
if s.repo == nil {
|
||||
return LoginResult{}, apperror.ErrUnavailable
|
||||
}
|
||||
login = strings.ToLower(strings.TrimSpace(login))
|
||||
if !loginPattern.MatchString(login) || len(password) > 72 || password == "" {
|
||||
return LoginResult{}, apperror.ErrUnauthenticated
|
||||
}
|
||||
user, credential, err := s.repo.FindCredential(ctx, login)
|
||||
if err != nil {
|
||||
if errors.Is(err, apperror.ErrNotFound) {
|
||||
_ = bcrypt.CompareHashAndPassword(s.dummyHash, []byte(password))
|
||||
return LoginResult{}, apperror.ErrUnauthenticated
|
||||
}
|
||||
return LoginResult{}, err
|
||||
}
|
||||
if bcrypt.CompareHashAndPassword([]byte(credential.PasswordHash), []byte(password)) != nil || user.Status != "ACTIVE" || (audience == "admin" && user.Role != "ADMIN") || (audience == "app" && user.Role != "USER") {
|
||||
return LoginResult{}, apperror.ErrUnauthenticated
|
||||
}
|
||||
raw := make([]byte, 32)
|
||||
if _, err := rand.Read(raw); err != nil {
|
||||
return LoginResult{}, fmt.Errorf("generate session token: %w", err)
|
||||
}
|
||||
token := base64.RawURLEncoding.EncodeToString(raw)
|
||||
expires := s.now().UTC().Add(8 * time.Hour)
|
||||
session := domain.Session{ID: uuid.NewString(), UserID: user.ID, TokenHash: TokenHash(token), Audience: audience, ExpiresAt: expires}
|
||||
if err := s.repo.CreateSession(ctx, session); err != nil {
|
||||
return LoginResult{}, err
|
||||
}
|
||||
return LoginResult{User: user, Token: token, ExpiresAt: expires}, nil
|
||||
}
|
||||
|
||||
func (s *AuthService) Authenticate(ctx context.Context, token, audience string) (domain.User, error) {
|
||||
if s.repo == nil {
|
||||
return domain.User{}, apperror.ErrUnavailable
|
||||
}
|
||||
if len(token) != 43 {
|
||||
return domain.User{}, apperror.ErrUnauthenticated
|
||||
}
|
||||
if audience != "admin" && audience != "app" {
|
||||
return domain.User{}, apperror.ErrUnauthenticated
|
||||
}
|
||||
user, err := s.repo.FindSessionUser(ctx, TokenHash(token), audience, s.now().UTC())
|
||||
if err != nil {
|
||||
return domain.User{}, err
|
||||
}
|
||||
if user.Status != "ACTIVE" || audience == "admin" && user.Role != "ADMIN" || audience == "app" && user.Role != "USER" {
|
||||
return domain.User{}, apperror.ErrUnauthenticated
|
||||
}
|
||||
return user, nil
|
||||
}
|
||||
|
||||
func (s *AuthService) Logout(ctx context.Context, token, audience string) error {
|
||||
if s.repo == nil {
|
||||
return apperror.ErrUnavailable
|
||||
}
|
||||
return s.repo.RevokeSession(ctx, TokenHash(token), audience, s.now().UTC())
|
||||
}
|
||||
|
||||
func (s *AuthService) ListUsers(ctx context.Context) ([]domain.User, error) {
|
||||
if s.repo == nil {
|
||||
return nil, apperror.ErrUnavailable
|
||||
}
|
||||
return s.repo.ListUsers(ctx, 100)
|
||||
}
|
||||
|
||||
func TokenHash(token string) string {
|
||||
sum := sha256.Sum256([]byte(token))
|
||||
return hex.EncodeToString(sum[:])
|
||||
}
|
||||
@@ -0,0 +1,92 @@
|
||||
package service
|
||||
|
||||
import (
|
||||
"context"
|
||||
"errors"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"veyra/services/api/internal/identity/domain"
|
||||
"veyra/services/api/internal/platform/apperror"
|
||||
)
|
||||
|
||||
type testRepository struct {
|
||||
user domain.User
|
||||
credential domain.Credential
|
||||
session domain.Session
|
||||
createdSessions int
|
||||
}
|
||||
|
||||
func (r *testRepository) CreateUser(_ context.Context, u domain.User, c domain.Credential) (domain.User, error) {
|
||||
r.user = u
|
||||
r.credential = c
|
||||
return u, nil
|
||||
}
|
||||
func (r *testRepository) FindCredential(_ context.Context, login string) (domain.User, domain.Credential, error) {
|
||||
if login != r.credential.LoginName {
|
||||
return domain.User{}, domain.Credential{}, apperror.ErrNotFound
|
||||
}
|
||||
return r.user, r.credential, nil
|
||||
}
|
||||
func (r *testRepository) CreateSession(_ context.Context, s domain.Session) error {
|
||||
r.session = s
|
||||
r.createdSessions++
|
||||
return nil
|
||||
}
|
||||
func (r *testRepository) FindSessionUser(_ context.Context, _, _ string, _ time.Time) (domain.User, error) {
|
||||
return r.user, nil
|
||||
}
|
||||
func (r *testRepository) RevokeSession(_ context.Context, _, _ string, _ time.Time) error { return nil }
|
||||
func (r *testRepository) ListUsers(context.Context, int) ([]domain.User, error) {
|
||||
return []domain.User{r.user}, nil
|
||||
}
|
||||
|
||||
func TestPasswordAndSessionSecretsAreHashed(t *testing.T) {
|
||||
ctx := context.Background()
|
||||
repo := &testRepository{}
|
||||
auth, err := NewAuthService(repo)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
password := "a-development-password"
|
||||
if _, err := auth.ProvisionUser(ctx, " ADMIN ", password, "Admin", "ADMIN"); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if repo.credential.PasswordHash == password || repo.credential.LoginName != "admin" {
|
||||
t.Fatal("credential handling failed")
|
||||
}
|
||||
result, err := auth.Login(ctx, "admin", password, "admin")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if len(result.Token) != 43 || repo.session.TokenHash == result.Token || repo.session.TokenHash != TokenHash(result.Token) {
|
||||
t.Fatal("raw session secret persisted")
|
||||
}
|
||||
if _, err := auth.Login(ctx, "admin", "incorrect-password", "admin"); !errors.Is(err, apperror.ErrUnauthenticated) {
|
||||
t.Fatal("wrong password accepted")
|
||||
}
|
||||
if _, err := auth.Login(ctx, "admin", password, "app"); !errors.Is(err, apperror.ErrUnauthenticated) {
|
||||
t.Fatal("admin credential used for app login")
|
||||
}
|
||||
if _, err := auth.Login(ctx, "missing", password, "admin"); !errors.Is(err, apperror.ErrUnauthenticated) {
|
||||
t.Fatal("missing identity was disclosed")
|
||||
}
|
||||
if repo.createdSessions != 1 {
|
||||
t.Fatal("failed login created a session")
|
||||
}
|
||||
repo.user.Status = "DISABLED"
|
||||
if _, err := auth.Authenticate(ctx, result.Token, "admin"); !errors.Is(err, apperror.ErrUnauthenticated) {
|
||||
t.Fatal("disabled user remained authenticated")
|
||||
}
|
||||
}
|
||||
|
||||
func TestUserCannotAuthenticateAsAdmin(t *testing.T) {
|
||||
repo := &testRepository{user: domain.User{Status: "ACTIVE", Role: "USER"}}
|
||||
auth, err := NewAuthService(repo)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if _, err := auth.Authenticate(context.Background(), "1234567890123456789012345678901234567890123", "admin"); !errors.Is(err, apperror.ErrUnauthenticated) {
|
||||
t.Fatal("user role passed admin authorization")
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user